Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DAV to the new bootstrap mechanism #21467

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Move DAV to the new bootstrap mechanism #21467

merged 1 commit into from
Jun 20, 2020

Conversation

ChristophWurst
Copy link
Member

Required for #20916

This does two things

  • Unify initialization code from app.php and Application to just the class
  • Use the new bootstrap mechanism to register the lazy stuff earlier

I just did a bit of a 🚬 test and the dev instance seems fine. CI will do the rest.

@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Jun 18, 2020
@ChristophWurst ChristophWurst self-assigned this Jun 18, 2020
georgehrke
georgehrke requested changes Jun 18, 2020
View reviewed changes
apps/dav/appinfo/app.php Outdated Show resolved Hide resolved
@ChristophWurst ChristophWurst force-pushed the enhancement/dav-bootstrap branch from 0fbcf67 to 01bb9ac Compare June 18, 2020 13:53
@vaneslie vaneslie removed their request for review June 18, 2020 13:54
@RussellAult RussellAult removed their request for review June 18, 2020 19:05
@ChristophWurst
Move DAV to the new bootstrap mechanism
1285be2 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the enhancement/dav-bootstrap branch from 58a1ae2 to 1285be2 Compare June 19, 2020 13:10
skjnldsv
skjnldsv approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code make sense

@ChristophWurst
Copy link
Member Author

DAV integration tests pass 🚀

The ususal sharing suspects fail 🤷

@rullzer rullzer merged commit d523925 into master Jun 20, 2020
@rullzer rullzer deleted the enhancement/dav-bootstrap branch June 20, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@cosenal cosenal Awaiting requested review from cosenal

@giulianograssi giulianograssi Awaiting requested review from giulianograssi

@tcitworld tcitworld Awaiting requested review from tcitworld

@LEDfan LEDfan Awaiting requested review from LEDfan

@inthreedee inthreedee Awaiting requested review from inthreedee

@vaneslie vaneslie Awaiting requested review from vaneslie

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews enhancement technical debt
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @georgehrke @juliusknorr @skjnldsv @rullzer