shortcut in reading nested group members when IN_CHAIN is available #21559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
rullzer,
ChristophWurst,
jasonbayton,
juliushaertl,
JSoko and
skjnldsv
|
/backport to stable19 |
|
/backport to stable18 |
blizzz
force-pushed
the
fix/noid/ldap-group-shortcut-ad
branch
2 times, most recently
from
180922c
to
e7edb1b
Compare
blizzz
force-pushed
the
fix/noid/ldap-group-shortcut-ad
branch
from
e7edb1b
to
5d85fe0
Compare
|
Let's wait for #16737 first and then rebase this one here. |
@MorrisJobke ping :) |
|
ah wait, while looking at another issue where this can help with, i found some more improvments |
blizzz
added
2. developing
…able Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/noid/ldap-group-shortcut-ad
branch
from
5d85fe0
to
f34be91
Compare
blizzz
added
3. to review
- the detection relies that the first, requested result is not empty - it might be empty though – groups without members - protect switching from available to unavailable - switching the other way around was also not envisaged either Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/noid/ldap-group-shortcut-ad
branch
from
f34be91
to
7eb6d8d
Compare
This comment has been minimized.
This comment has been minimized.
This was referenced Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, to support members in nested groups, we cycle through them. Some LDAP server do implement the LDAP_MATCHING_RULE_IN_CHAIN (aka 1.2.840.113556.1.4.1941) extensible matcher (AD, Samba 4), which would speed up reading of group members drastically.
This matcher can not be used blindly, as server that do not implement it, return empty results. To avoid testing every time, the state is saved in the configuration, so that when working in servers that do not support this mechanism, it is not being attempted all over again.