Dashboard frontend enhancements

[juliushaertl]

Follow up PR to #21346

• Implement dynamic sorting and adding/removing panels
• Only show name if display name is set.
• Make dashboard the default app
• Check if we can make the default app dynamic depending on a user setting
• UI needs polishing
• Integrate status feature
• Rename API to use the term Widget instead of Panel
• App store category for apps supporting dashboard Add dashboard category appstore#737
• Link to the new app store category

[ChristophWurst]

to be more compliant to what REST is about I would suggest to restructure this to be a resource, like simply /dashboard/layout and POST the data there

[juliushaertl]

I'd look into this in a separate pr since my first attempt for that didn't work out as expected.

[jancborchardt]

@juliushaertl needs a rebase. :)

Also:

Decide if this should be the default app and how the order of apps should be in the app menu

I would say we make this the default app in master so we can properly dogfood it. We can still decide later before the RCs or so to keep Files the default. Ok @karlitschek @rullzer?

[karlitschek]

@jancborchardt agreed

[MorrisJobke]

I reverted the URL change in the acceptance tests. The dashboard app should be disabled in those anyways. So this should fix those failing tests.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31436: failure

jsunit

Show full log

PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (10.756 secs / 10.188 secs)

acceptance-app-files

• tests/acceptance/features/app-files.feature:262

Show full log

  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
      Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

[skjnldsv]

Tests failures unrelated