Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chmod on file descriptor #21676

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Fix chmod on file descriptor #21676

merged 1 commit into from
Jul 7, 2020

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Jul 3, 2020

This fixes an error when a file descriptor or unix device file is used as log file.
chmod(): Operation not permitted at /var/www/html/lib/private/Log/File.php

@J0WI
Fix chmod on file descriptor
6ca1599 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@J0WI J0WI added 3. to review Waiting for reviews feature: logging php Pull requests that update Php code labels Jul 3, 2020
@MorrisJobke MorrisJobke added this to the Nextcloud 20 milestone Jul 6, 2020
kesselb
kesselb approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder that you see that error at all. The chmod operation is silenced. The failure should not end up in your log.

@MorrisJobke MorrisJobke merged commit cd7a627 into nextcloud:master Jul 7, 2020
@J0WI J0WI deleted the fix-chmod-on-fd branch July 7, 2020 14:28
@J0WI
Copy link
Contributor Author

J0WI commented Aug 12, 2020

/backport to stable19

@J0WI
Copy link
Contributor Author

J0WI commented Aug 12, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 12, 2020
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: logging php Pull requests that update Php code
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
4 participants
@J0WI @MorrisJobke @ChristophWurst @kesselb