Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused method uploadFile #21788

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Remove unused method uploadFile #21788

merged 1 commit into from
Aug 13, 2020

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 10, 2020

Method is unused according to PHPStorm.

apps/files_external/lib/Lib/Storage/SFTP.php:438:47:error - UndefinedConstant: Const NET_SFTP_LOCAL_FILE is not defined

Also NET_SFTP_LOCAL_FILE has been renamed to phpseclib\Net\SFTP::SOURCE_LOCAL_FILE a while ago (phpseclib 1.x to 2.x).

@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Jul 10, 2020
@kesselb kesselb added this to the Nextcloud 20 milestone Jul 10, 2020
@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
57 tasks
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@icewind1991 your call

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@faily-bot
Copy link

faily-bot bot commented Aug 13, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31736: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@rullzer rullzer merged commit 34cd498 into master Aug 13, 2020
@rullzer rullzer deleted the debt/noid/unused-method branch August 13, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants