Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate encryption to the PSR container #21860

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Migrate encryption to the PSR container #21860

merged 1 commit into from
Oct 7, 2020

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jul 16, 2020 •
edited
Loading

📜 nextcloud/documentation#2202

⚠️ I did not test more than a little smoke test to see if this causes major issues in other parts of Nextcloud

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Jul 16, 2020
@ChristophWurst ChristophWurst self-assigned this Jul 16, 2020
@ChristophWurst ChristophWurst force-pushed the techdebt/encryption-psr-container branch from e2f9acc to 34488c5 Compare July 16, 2020 13:48
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews enhancement technical debt and removed 2. developing Work in progress labels Jul 16, 2020
@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Jul 16, 2020
@ChristophWurst ChristophWurst marked this pull request as ready for review July 16, 2020 13:49
@MorrisJobke MorrisJobke mentioned this pull request Aug 11, 2020
Merged
57 tasks
@ChristophWurst ChristophWurst force-pushed the techdebt/encryption-psr-container branch from 34488c5 to 1a319ac Compare October 7, 2020 07:01
MorrisJobke
MorrisJobke approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but this should really be moved to auto-wiring and usage of the namespaced class names instead of random strings 🙈 🙉 🙊

@MorrisJobke

This comment has been minimized.

Sign in to view
@ChristophWurst
Migrate encryption to the PSR container
8033655 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the techdebt/encryption-psr-container branch from 1a319ac to 8033655 Compare October 7, 2020 13:34
@MorrisJobke MorrisJobke merged commit 3f78639 into master Oct 7, 2020
@MorrisJobke MorrisJobke deleted the techdebt/encryption-psr-container branch October 7, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@rullzer rullzer Awaiting requested review from rullzer

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews enhancement technical debt
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @MorrisJobke @nickvergessen