-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Event and Task Backends for Unified Search #22020
Conversation
7e92ba9
to
13c20bb
Compare
80a1c0e
to
12674f7
Compare
43a276c
to
8513c98
Compare
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
8513c98
to
900617e
Compare
(Clicking an event in the list currently redirects to files. The link itself is correct, it's just an issue in the calendar app) |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31359: failuresqliteShow full log
|
Unrelated failures |
To solve that easily (at least I guess it’s easy) we can simply omit the year if it’s the current one. :) Less info clutter, quicker to read as well. |
|
||
$principalUri = 'principals/users/' . $user->getUID(); | ||
$calendarsById = $this->getSortedCalendars($principalUri); | ||
$subscriptionsById = $this->getSortedSubscriptions($principalUri); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't show subscriptions in Tasks at the moment. I guess when a VTODO in a subscription is matched, the corresponding route in Tasks won't exist. We could also show subscriptions in the Tasks app of course, but we decided not to for now nextcloud/tasks#910.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine. Tasks are found as they should.
What I just noticed: @georgehrke @skjnldsv Can the |
No idea! 🤔 |
We are already aware of that issue: #22092 (comment) |
I have no idea, maybe try to get #22099 in so we can do followups |
Did you see that btw @georgehrke @skjnldsv – just want to make sure it doesn’t go under, as it significantly reduces the information overload there. |
Mostly for @georgehrke then :p |
Fixes #20918
Fixes nextcloud/calendar#8
I'm not super happy about the ellipsis for the Foo 4 event, but we can look into better solutions later.