-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User-Status Followup #22109
User-Status Followup #22109
Conversation
f016533
to
d221d14
Compare
d221d14
to
ba3f0e9
Compare
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
9116399
to
b457a4e
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31817: failurejsunitShow full log
acceptance-app-files
Show full log
|
$result['status'] = [ | ||
'status' => $userStatus->getStatus(), | ||
'message' => $userStatus->getMessage(), | ||
'icon' => $userStatus->getIcon(), | ||
'clearAt' => $userStatus->getClearAt() | ||
? (int)$userStatus->getClearAt()->format('U') | ||
: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you're also usingthis code on lib/private/Collaboration/Collaborators/UserPlugin.php
Maybe it would make sense as a dedicated function? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about about that as well, but then it's merely 6 lines of code and it's in two completely different components (an app vs. class in private OC namespace)
/compile amend / |
adb7810
to
e395687
Compare
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
e395687
to
40bf38a
Compare
Related Issue: #20931
Previous PR: #21186
Requires nextcloud-libraries/nextcloud-vue#1259