-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete chunks if the move on an upload failed #22128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
Tests fail. |
Also the part file is still in the users home directory. Shouldn't it be deleted as well (this hasn't changed at all between master and this branch, but I just noticed it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
99f79d3
to
0e45c99
Compare
Autosquashed and force pushed |
|
Are you sure that those are not from previous uploads? Then they should be cleaned up after 24 hours iirc. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
0e45c99
to
cda5cfc
Compare
Hm i assume this is also related.
I'll have another look |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Should be aligned to the previous behavior now as https://github.com/nextcloud/3rdparty/blob/b0afba6d6508a1c85332cf8c61e90ad91b289ebc/sabre/dav/lib/DAV/CorePlugin.php#L653 was called before Let's see what CI thinks about that. |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31762: failuresqliteShow full log
acceptance-app-files
Show full log
|
@juliushaertl I guess we backport this down to stable17? |
/backport to stable19 |
/backport to stable18 |
/backport to stable17 |
This should fix #16517 where chunks don't get cleaned up if the move operation after a chunked upload fails for some reason, e.g. because the file is blocked by files_accesscontrol.
Steps to reproduce: