-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add highcontrast class to body just like with dark theme #22195
Conversation
@@ -90,6 +90,7 @@ export default { | |||
// SELECT handlers | |||
selectHighContrast(id) { | |||
this.selectItem('highcontrast', id) | |||
document.body.classList.toggle('highcontrast') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually have preferred a better generic class.
Like I don't know, theme--highcontrast
Ideallyu with BEM syntax like we're using in lots of other areas :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll leave that up to you then – also theme--dark would be nice, but then we need to adjust it in places where we used it? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it used really in other locations? I actually never saw it before.
Also, I was not really aware of this and I figure it would be nice to maybe discuss a proper standard before? Did I miss something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that all of that is about dark mode, not high contrast though.
Is it used really in other locations? I actually never saw it before.
I’m using it in Dashboard now, since that’s the easiest way to check via CSS if dark mode is enabled.
So I’ll just use theme--highcontrast
for the high contrast mode now and we can do the dark mode stuff separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since that was available for quite some time and apps are using it, add it to the dev notes please.
Deck also used body.dark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx Joas :)
015842c
to
e168cb2
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31636: failureacceptance-app-files
Show full log
|
@skjnldsv I changed the class to |
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
e168cb2
to
aa16550
Compare
Need this for adjustments in the Dashboard app, just like with the
.dark
class. :)