Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] Properly search for users when limittogroups is enabled #22355

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #20772

rullzer and others added 2 commits August 21, 2020 11:23
Searching just for the uid is not enough.
This makes sure this done properly again now.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
…ed to contain more results

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@faily-bot
Copy link

faily-bot bot commented Aug 21, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32181: failure

mysql8.0-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #220 ('folder', 27, 29)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:366

acceptance-users

  • tests/acceptance/features/users.feature:25
Show full log
  Scenario: delete a user                                    # /drone/src/tests/acceptance/features/users.feature:25
    Given I act as Jane                                      # ActorContext::iActAs()
    And I am logged in as the admin                          # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                             # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user user0           # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user user0 in Users Settings could not be found
      Actions menu for user user0 in Users Settings could not be found (NoSuchElementException)

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Aug 21, 2020
@rullzer rullzer merged commit 9aac6d9 into stable19 Aug 24, 2020
@rullzer rullzer deleted the backport/20772/stable19 branch August 24, 2020 07:12
@rullzer rullzer mentioned this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants