Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CRL #22385

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Update the CRL #22385

merged 1 commit into from
Aug 24, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Aug 24, 2020

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review Waiting for reviews label Aug 24, 2020
@rullzer rullzer added this to the Nextcloud 20 milestone Aug 24, 2020
@rullzer
Copy link
Member Author

rullzer commented Aug 24, 2020

/backport to stable19

@rullzer
Copy link
Member Author

rullzer commented Aug 24, 2020

/backport to stable18

@rullzer
Copy link
Member Author

rullzer commented Aug 24, 2020

/backport to stable17

@faily-bot
Copy link

faily-bot bot commented Aug 24, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32236: failure

mysql8.0-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGetSharedWithGroupUserModified with data set #0 ('home::shareOwner', 'files/test.txt', 'files/test2.txt')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'0'
+'52'

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1118

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
      Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@rullzer rullzer merged commit 341466b into master Aug 24, 2020
@rullzer rullzer deleted the bump/crl branch August 24, 2020 11:24
@rullzer rullzer mentioned this pull request Aug 25, 2020
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants