Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] Fix missing FN from federated contact #22400

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #22394

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Aug 24, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 24, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32263: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\ScannerTest::testShallow
Failed asserting that true matches expected false.

/drone/src/tests/lib/Files/Cache/ScannerTest.php:134

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 2 failures:

1) Test\Files\Storage\Wrapper\PermissionsMaskTest::testScanUnchangedWrapped
Failed asserting that true is false.

/drone/src/tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php:177

2) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:730

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will have to wait for 19.0.3

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah 1 line change... ok...

@rullzer rullzer merged commit 5cf3c27 into stable19 Aug 25, 2020
@rullzer rullzer deleted the backport/22394/stable19 branch August 25, 2020 07:38
@rullzer rullzer mentioned this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants