Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable18] Fix missing FN from federated contact #22401

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #22394

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Aug 24, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 24, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32264: failure

mysql5.6-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #131 ('folder', 23, 31)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:361

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@rullzer rullzer merged commit ead4d98 into stable18 Aug 25, 2020
@rullzer rullzer deleted the backport/22394/stable18 branch August 25, 2020 07:38
@rullzer rullzer mentioned this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants