Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention in the settings the side effect of outgoing federated shares #22852

Conversation

danxuliu
Copy link
Member

Until #20132 is fixed* the checkbox should explicitly mention its unexpected side effect.

*Note that the steps to reproduce mention using the viewer; the viewer case was fixed in nextcloud/viewer#581, but the issue of not being able to access public shares using WebDAV when outgoing federated shares are disabled is still valid

The wording of the option is just a suggestion; feel free to improve it :-)

When/If this is merged the user manual should be updated to reflect the new text in the settings.

Should this be backported to stable19 and stable18?

Currently outgoing federated shares need to be enabled to allow WebDAV
access to public shares.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu added bug 3. to review Waiting for reviews feature: settings pending documentation This pull request needs an associated documentation update labels Sep 15, 2020
@danxuliu danxuliu added this to the Nextcloud 20 milestone Sep 15, 2020
@danxuliu danxuliu mentioned this pull request Sep 15, 2020
5 tasks
@faily-bot
Copy link

faily-bot bot commented Sep 15, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33063: failure

mariadb10.4-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 2 failures:

1) Test\Files\Cache\UpdaterLegacyTest::testWrite
Failed asserting that 3619 matches expected 3606.

/drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:101

2) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #17 ('folder', 1, 21)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 15, 2020
@rullzer rullzer merged commit 74e0b50 into master Sep 15, 2020
@rullzer rullzer deleted the mention-in-the-settings-the-side-effect-of-outgoing-federated-shares branch September 15, 2020 08:12
@danxuliu danxuliu removed the pending documentation This pull request needs an associated documentation update label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants