-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity notifications for groupmates by Comments (when using Group Folder app) #23036
Closed
ghost
wants to merge
1
commit into
nextcloud:master
from
chrisfritsche:update/comment_notifications_for_group_folders
Closed
Activity notifications for groupmates by Comments (when using Group Folder app) #23036
ghost
wants to merge
1
commit into
nextcloud:master
from
chrisfritsche:update/comment_notifications_for_group_folders
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
update/comment_notifications_for_group_folders
branch
from
September 24, 2020 13:58
1803c5f
to
d156170
Compare
Hi @nickvergessen and @ChristophWurst ! Pls, when you have time, could you make the review on this PR? Thanks a lot in advance!! |
ghost
changed the title
Activity notifications for groupmaters by Comments (when using Group Folder app)
Activity notifications for groupmates by Comments (when using Group Folder app)
Sep 24, 2020
ghost
mentioned this pull request
Oct 2, 2020
nickvergessen
approved these changes
Oct 12, 2020
/backport to stable20 |
ChristophWurst
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🐘
nickvergessen
approved these changes
Nov 16, 2020
@chrisfritsche can you rebase one last time? |
Signed-off-by: Chris Fritsche <chris.fritsche@cunio.de>
MorrisJobke
force-pushed
the
update/comment_notifications_for_group_folders
branch
from
January 7, 2021 20:49
d156170
to
3a16939
Compare
I rebased. |
MorrisJobke
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jan 7, 2021
CI is not happy |
rullzer
removed
the
4. to release
Ready to be released and/or waiting for tests to finish
label
Jan 8, 2021
Merged
/rebase |
Merged
Merged
Merged
Merged
Merged
Merged
Closing for inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently:
Comments on files in group folders does not generate activity notifications for the groupmates.
With this PR:
Also include groupmates to receive the notifications.