Improve user share suggestions #23265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinimodmeyer
changed the title
added 3 commits
October 8, 2020 09:16
… as well keep whitespace for more excat search. Signed-off-by: Dominik Meyer <kinimodmeyer@gmail.com>
Signed-off-by: Dominik Meyer <kinimodmeyer@gmail.com>
Signed-off-by: Dominik Meyer <kinimodmeyer@gmail.com>
|
"continuous-integration/drone/pr" failed but i don´t see the reason in https://drone.nextcloud.com/nextcloud/server/33829/14/5 ? can someone give me a hint or is it a pipeline issue? how is the process overall here now. @nickvergessen @schiessle |
|
It had a timeout, it's okay to ignore it. |
nickvergessen
requested changes
Oct 12, 2020
Comment on lines
+281
to
+289
| $serverAbsolutePath = \OC::$server->getURLGenerator()->getAbsoluteURL('/'); | ||
| $serverFederationPath = rtrim(\OC\Share\Share::removeProtocolFromUrl($serverAbsolutePath), '/'); | ||
|
|
||
| /* | ||
| * the given search looks like a local federation. | ||
| */ | ||
| if (mb_strpos($search, '@'.$serverFederationPath) !== false) { | ||
| $query->orWhere($query->expr()->eq('uid', $query->createPositionalParameter(explode('@', $search)[0]))); | ||
| } |
There was a problem hiding this comment.
This should not be here from my pov.
There was a problem hiding this comment.
thanks for your review @nickvergessen
can you give me a little more information what you mean with this?
do you mean it should be in another class/method and somehow gets injected there?
There was a problem hiding this comment.
Well "federation a like" results are returned by other search plugins?
Signed-off-by: Dominik Meyer <kinimodmeyer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1963
@jancborchardt wrote the best way to start is to pick a issues with label "good first issue".
that´s why i just choosed this issue here from the list. ⛏️
this is my first contribution so be friendly 😺
PS next to my code contribution is saw this code-comment:
i not understand this comment exactly, what is not possible with sqlite?
my change works in sqlite even tho i reuse the same column (uid), but i guess this comment means something else.
PPS i personally would love 🥰 to find the user if you start with typing the lastname like "Meyer Dominik". but this is out of scope here i guess.