Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External delete directly #23489

Closed
wants to merge 5 commits into from
Closed

External delete directly #23489

wants to merge 5 commits into from

Conversation

dassio
Copy link

@dassio dassio commented Oct 15, 2020

same as #22632

I accidentally deleted the forked repo, here i created a new repo and did a rebase

Edit: @jancborchardt @icewind1991 @ChristophWurst please help to review

Signed-off-by: xiangbin.li <dassio@icloud.com>
Signed-off-by: xiangbin.li <dassio@icloud.com>
Signed-off-by: xiangbin.li <dassio@icloud.com>
Signed-off-by: xiangbin.li <dassio@icloud.com>
Signed-off-by: xiangbin.li <dassio@icloud.com>
@kevinkk525
Copy link

Thank you for implementing this! Have been looking forward to this feature for a very very long time.

(Hope it'll make it to Nextcloud 20.01 and 19.05 soon :-) )

@rullzer
Copy link
Member

rullzer commented Oct 19, 2020

Thank you for implementing this! Have been looking forward to this feature for a very very long time.

(Hope it'll make it to Nextcloud 20.01 and 19.05 soon :-) )

won't. We don't backport features

@kevinkk525
Copy link

:( nextcloud 20 was just released. 21 will take ages and this is basically a bugfix for external_storages.. but ok. Thanks for the answer, at least now I know not to expect it anytime soon.

This was referenced Dec 14, 2020
This was referenced Dec 28, 2020
@MorrisJobke MorrisJobke modified the milestones: Nextcloud 21, Nextcloud 22 Jan 7, 2021
@szaimen
Copy link
Contributor

szaimen commented May 11, 2021

Any update here? :)

@szaimen
Copy link
Contributor

szaimen commented May 11, 2021

BTW: would it be possible to move the deleted files onto a hidden directory that is in the root directory of the external storage instead of deleting them permanently or is this much harder to implement than just deleting them? I mean they wouldn't necessarily need to be shown in Nextclouds trashbin app if this switch is enabled...

@MorrisJobke MorrisJobke removed their request for review May 17, 2021 07:32
This was referenced May 20, 2021
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@blizzz blizzz removed this from the Nextcloud 22 milestone Jun 2, 2021
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 21, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@InfamousUser
Copy link

Any update on this?

@jancborchardt
Copy link
Member

@PVince81 @skjnldsv @szaimen since it doesn't seem @dassio will update this, what's your call: We rebase & review it, or we close it?

@szaimen
Copy link
Contributor

szaimen commented May 16, 2022

We rebase & review it, or we close it?

I could try to rebase it but question is if we want this since it seems like it was not getting much attention...

Maybe lets also ping @artonge and @CarlSchwan ...

@artonge
Copy link
Contributor

artonge commented May 16, 2022

Same opinion as @szaimen, @jancborchardt if you think this make sens for Nextcloud then we'll push to have it merged :)

@jancborchardt
Copy link
Member

Product-wise we don't seem to have gotten requests for it, and I was also unsure about it in the previous pull request. So I'd say we close for now, can always be revived by someone who wants to work on it.

@InfamousUser
Copy link

Damn, looks like I carpet bombed the thread.

@gmaxbass
Copy link

gmaxbass commented Jun 3, 2022

Hi,
too I'm in the need to delete files from external storage since my users need to manage big file sizes. I think that moving external files to user's trash bin for deletion is not a working solution neither technically efficient and it's resource/time consuming.
So the alternatives are:

  1. Create a ".trash" in each external storage mount

or

  1. Enable an option to delete permanently files on external storage without moving them in user's trash bin.

Maybe the second option it's a bit wiser..it'll be up to admin decide or not to enable it and inform their users about it.

I think that this needs to be fixed.

@kevinkk525
Copy link

kevinkk525 commented Jun 4, 2022 via email

@ryester19
Copy link

This would be useful for my setup, also. I use external S3 storage for very large files that gets deleted regularly, and having the deletes move it to my smaller primary storage is often a burden

@ikwtif
Copy link

ikwtif commented Dec 30, 2022

This is definitely needed, I'm honestly surprised deletions aren't just moved to a hidden trash folder on the same storage by default for external storage. In its current form this makes external storage quite useless to me.
My setup just has a drive that's too small to cover large deletion of files in the trash bin, this is the reason why I'm also using external storage for most of my data.

@Oriann
Copy link

Oriann commented Nov 3, 2023

How is it going ? My files from external storage still move to local trash bin..

@Grubersky
Copy link

Was happy to see that this problem got addressed, but sad to see that it didn't make it all the way in the end. I do understand why, though. Still hoping that this feature makes it at some point into Nextcloud.

@labor4
Copy link
Contributor

labor4 commented Mar 29, 2024

Very sorry too to see this fading.

We do video filesharing, usually with multiples of GB filesizes, on multiple of filesystems (for backup tiering).
Earlier we just disabled the "Deleted Files" App to prevent system hangups. But in the current NC version this produces missing-class errors.

Moving GBs of trash across FS'es is no comfort, because it is so very heavy.
An in-FS rename should do this.

Having a .trash bin on each filesystem is a very old concept, proven and very fast.
Yes, it requires a transparent merge in the GUI, cross-FS, but the underlying reason is essential.

Otherwise there is a strong need to safely disable the trash completely, without errors.

Thank you.

@albert-a
Copy link

albert-a commented Aug 9, 2024

Indeed, in every storage system I've dealt with, deletions are done by moving items to a trash folder on the same file system, rather than copying them anywhere. I'm surprised that NC does things differently. I really wish it were implemented!

Like many of the people mentioned above, I too have a small, fast NC setup on NVMe with attached storage, and deletions quickly eat up the free space on the system disk.

@jancborchardt
Copy link
Member

Since this is now indeed requested a lot, it’s something to re-evaluate @sorbaugh @AndyScherzinger

@Oriann
Copy link

Oriann commented Aug 22, 2024

I wish this will be worked out soon. I have a terabytes of videos and moving them to trash bin to another (smaller) fs is a really big problem. I look forward to improving this.

@albert-a
Copy link

I'm just writing to say that it is still relevant. My Nextcloud instance hangs about every 3 weeks (root disk is full):

Internal Server Error

The server encountered an internal error and was unable to complete your request.
Please contact the server administrator if this error reappears multiple times, please include the technical details below in your report.
More details can be found in the server log.

Desktop client shows:
Screenshot 2024-09-11 at 21 18 56

The way I resolve it:

  • I extend the root disk a little
  • Now the users are able to login to Nextcloud and empty their trashes.
  • Breath normally :)

@Gugiman
Copy link

Gugiman commented Oct 2, 2024

Just for pushing the need for this feature, I also suffer from files beeing downloaded from external filesystem to the smaller local one...
Also I'm paying for every GB i downloaded from my S3 Storage...

So there is also a monetary reason for this.

@sorbaugh
Copy link
Contributor

sorbaugh commented Oct 7, 2024

Fyi this topic has gained a lot of traction lately, we looked into reopening this PR but due to the frontend having been migrated to vue and a few other backend-side nitpicks, it would be better to create a PR from scratch.

Still, thank you very much for this! It motivated us to re-discuss this topic which will definitely make Nextcloud better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.