-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External delete directly #23489
External delete directly #23489
Conversation
Signed-off-by: xiangbin.li <dassio@icloud.com>
Signed-off-by: xiangbin.li <dassio@icloud.com>
Signed-off-by: xiangbin.li <dassio@icloud.com>
Signed-off-by: xiangbin.li <dassio@icloud.com>
Signed-off-by: xiangbin.li <dassio@icloud.com>
Thank you for implementing this! Have been looking forward to this feature for a very very long time. (Hope it'll make it to Nextcloud 20.01 and 19.05 soon :-) ) |
won't. We don't backport features |
:( nextcloud 20 was just released. 21 will take ages and this is basically a bugfix for external_storages.. but ok. Thanks for the answer, at least now I know not to expect it anytime soon. |
Any update here? :) |
BTW: would it be possible to move the deleted files onto a hidden directory that is in the root directory of the external storage instead of deleting them permanently or is this much harder to implement than just deleting them? I mean they wouldn't necessarily need to be shown in Nextclouds trashbin app if this switch is enabled... |
Any update on this? |
I could try to rebase it but question is if we want this since it seems like it was not getting much attention... Maybe lets also ping @artonge and @CarlSchwan ... |
Same opinion as @szaimen, @jancborchardt if you think this make sens for Nextcloud then we'll push to have it merged :) |
Product-wise we don't seem to have gotten requests for it, and I was also unsure about it in the previous pull request. So I'd say we close for now, can always be revived by someone who wants to work on it. |
Damn, looks like I carpet bombed the thread. |
Hi,
or
Maybe the second option it's a bit wiser..it'll be up to admin decide or not to enable it and inform their users about it. I think that this needs to be fixed. |
+1 same for my setup.
|
This would be useful for my setup, also. I use external S3 storage for very large files that gets deleted regularly, and having the deletes move it to my smaller primary storage is often a burden |
This is definitely needed, I'm honestly surprised deletions aren't just moved to a hidden trash folder on the same storage by default for external storage. In its current form this makes external storage quite useless to me. |
How is it going ? My files from external storage still move to local trash bin.. |
Was happy to see that this problem got addressed, but sad to see that it didn't make it all the way in the end. I do understand why, though. Still hoping that this feature makes it at some point into Nextcloud. |
Very sorry too to see this fading. We do video filesharing, usually with multiples of GB filesizes, on multiple of filesystems (for backup tiering). Moving GBs of trash across FS'es is no comfort, because it is so very heavy. Having a .trash bin on each filesystem is a very old concept, proven and very fast. Otherwise there is a strong need to safely disable the trash completely, without errors. Thank you. |
Indeed, in every storage system I've dealt with, deletions are done by moving items to a trash folder on the same file system, rather than copying them anywhere. I'm surprised that NC does things differently. I really wish it were implemented! Like many of the people mentioned above, I too have a small, fast NC setup on NVMe with attached storage, and deletions quickly eat up the free space on the system disk. |
Since this is now indeed requested a lot, it’s something to re-evaluate @sorbaugh @AndyScherzinger |
I wish this will be worked out soon. I have a terabytes of videos and moving them to trash bin to another (smaller) fs is a really big problem. I look forward to improving this. |
I'm just writing to say that it is still relevant. My Nextcloud instance hangs about every 3 weeks (root disk is full):
The way I resolve it:
|
Just for pushing the need for this feature, I also suffer from files beeing downloaded from external filesystem to the smaller local one... So there is also a monetary reason for this. |
Fyi this topic has gained a lot of traction lately, we looked into reopening this PR but due to the frontend having been migrated to vue and a few other backend-side nitpicks, it would be better to create a PR from scratch. Still, thank you very much for this! It motivated us to re-discuss this topic which will definitely make Nextcloud better! |
same as #22632
I accidentally deleted the forked repo, here i created a new repo and did a rebase
Edit: @jancborchardt @icewind1991 @ChristophWurst please help to review