Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inform the user when flow config data exceeds thresholds #23752

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Oct 28, 2020

When providing check values or operation data (the stuff for action), you'll be informed when sending too much. The limits are now 2 and 4kB respectively, which should be sufficient for any flow configuration. Um, … ever ;)

Screenshot_20201028_140922

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 28, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 28, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34686: failure

mariadb10.1-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testSearch with data set "case insensitive" ('john', array('FN'), array(), array(array('uri0', 'John Doe'), array('uri1', 'John M. Doe')))
Failed asserting that 1 is identical to 2.

/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:746

mariadb10.4-php7.4

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\ScannerTest::testBackgroundScanNestedIncompleteFolders
Failed asserting that false is true.

/drone/src/tests/lib/Files/Cache/ScannerTest.php:220

@blizzz blizzz merged commit 6b2cf46 into master Oct 28, 2020
@blizzz blizzz deleted the fix/noid/wfe-ux-errors branch October 28, 2020 15:05
@blizzz
Copy link
Member Author

blizzz commented Oct 28, 2020

/backport to stable20

@blizzz
Copy link
Member Author

blizzz commented Oct 28, 2020

/backport to stable19

@blizzz
Copy link
Member Author

blizzz commented Oct 28, 2020

/backport to stable18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants