-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the matching on ancient /ocs routes #23820
Conversation
The appframework has been the default for quite some time now. So time to take proper advantage of it. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34834: failuremysql5.6-php7.3Show full log
|
@kesselb Any idea about those random Psalm failures? |
Note that before this pull request It seems that It can also be reproduced in a real instance:
If user B now logs in the shared file will be in the root instead of in the Talk folder. However, if now, while user B is logged in, user A shares another file in the conversation and user B reloads the Files app the new shared file will be in the Talk folder of user B. |
The tests in Talk are broken on master, see nextcloud/spreed#4736. It likely makes more sense to load the apps before handling login, because some apps might do stuff at that time. |
Let's revert this then and try to fix it better in 22 |
it might be enough to move loadApps() to the top to not change the initialization order I tried automatic revert and it failed, will need to do manually |
here's a PR that just changes the order: #24628 I guess in the future if we want to fix the order we might need to make it a v3.php and allow enough time for apps to migrate... |
The appframework has been the default for quite some time now. So time
to take proper advantage of it.
Should shave off matching and loading some routes. Should help with response times for OCS routes.