-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set frame-ancestors to none if none are filled #24189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Nov 17, 2020
juliusknorr
approved these changes
Nov 17, 2020
Seems some tests need adjustments. |
juliusknorr
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Nov 17, 2020
rullzer
force-pushed
the
enh/csp/frame-ancestors
branch
from
November 17, 2020 19:21
04d0357
to
70a3a36
Compare
frame-ancestors doesn't fall back to default-src. So when we apply a very restricted CSP we should make sure to set it to 'none' and not leave it empty. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
enh/csp/frame-ancestors
branch
from
November 18, 2020 09:13
70a3a36
to
9163790
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 35668: failuremysql8.0-php7.4Show full log
|
rullzer
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
2. developing
Work in progress
labels
Nov 18, 2020
/backport to stable20 |
1 similar comment
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frame-ancestors doesn't fall back to default-src. So when we apply a
very restricted CSP we should make sure to set it to 'none' and not
leave it empty.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl