Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of languages #2423

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Fix naming of languages #2423

merged 1 commit into from
Dec 1, 2016

Conversation

MorrisJobke
Copy link
Member

Now looks like this:

bildschirmfoto 2016-11-30 um 15 20 13

Instead of what it looked like before (with many not really translated languages):

bildschirmfoto 2016-11-30 um 15 20 27

bildschirmfoto 2016-11-30 um 15 20 34

bildschirmfoto 2016-11-30 um 15 20 37

cc @rullzer @nickvergessen @LukasReschke

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Nov 30, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Nov 30, 2016
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @jancborchardt and @icewind1991 to be potential reviewers.

@MorrisJobke MorrisJobke mentioned this pull request Nov 30, 2016
67 tasks
@rullzer
Copy link
Member

rullzer commented Dec 1, 2016

👍

@jancborchardt
Copy link
Member

@MorrisJobke so before there were a lot more languages in the list, without proper title but also some with a good title. Do we now do the cutoff by translation percentage or what? If so, what percentage do we cut off at?

Because you could argue that even having 30% or so translated is better than nothing, and then we have the »Help translate« link to get involved.

@MorrisJobke
Copy link
Member Author

@MorrisJobke so before there were a lot more languages in the list, without proper title but also some with a good title. Do we now do the cutoff by translation percentage or what? If so, what percentage do we cut off at?

We cut off at 50% of translation of core/ l10n. Most of the languages in there were only dummy leftovers. And they will reappear once the translation percentage raises.

@MorrisJobke
Copy link
Member Author

We cut off at 50% of translation of core/ l10n. Most of the languages in there were only dummy leftovers. And they will reappear once the translation percentage raises.

https://www.transifex.com/nextcloud/nextcloud/core/

Just check it out. But the actual percentage has nothing to do with this PR. This only cleans up. So feel free to +1 this one here and I can change the percentage to a lower value over in the tranifex script.

@LukasReschke
Copy link
Member

LGTM

@LukasReschke LukasReschke merged commit 1eab2a6 into master Dec 1, 2016
@LukasReschke LukasReschke deleted the fix-language-names branch December 1, 2016 12:39
@jancborchardt
Copy link
Member

@MorrisJobke ah ok, it was only dummies. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants