Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable18] Fix contacts menu position in sharing sidebar #24332

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

juliusknorr
Copy link
Member

Manual backport of #24331 since 18 requires a version bump of the vue library.

image

image

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@faily-bot
Copy link

faily-bot bot commented Nov 24, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35885: failure

webpack-build

handlebars

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testMove with data set #6 ('/sòurcē.txt', '/tärgét.txt')
Expected /tärgét.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that false matches expected 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'.

/drone/src/tests/lib/Files/Storage/Storage.php:207
/drone/src/tests/lib/Files/ObjectStore/ObjectStoreStorageTest.php:100

@juliusknorr juliusknorr marked this pull request as ready for review November 24, 2020 14:32
@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 24, 2020
@juliusknorr juliusknorr added this to the Nextcloud 18.0.12 milestone Nov 24, 2020
@rullzer rullzer merged commit 2f945aa into stable18 Nov 24, 2020
@rullzer rullzer deleted the bugfix/stable18/fix-contactsmenu-position branch November 24, 2020 18:35
This was referenced Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants