Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Fix the config key on the sharing expire checkbox #24346

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #24341

We don't use `shareapi_internal_enforce_expire_date` anywhere.
`shareapi_enforce_internal_expire_date` is the one we want.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@faily-bot
Copy link

faily-bot bot commented Nov 24, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35900: failure

mariadb10.4-php7.3

Show full log
There was 1 error:

1) OCA\DAV\Tests\unit\CalDAV\CalDavBackendTest::testSubscriptions
TypeError: Argument 2 passed to OCA\DAV\Events\SubscriptionCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 2142

/drone/src/apps/dav/lib/Events/SubscriptionCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:2142
/drone/src/apps/dav/tests/unit/CalDAV/CalDavBackendTest.php:538

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mysql8.0-php7.2

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@skjnldsv
Copy link
Member

Failure unrelated

@skjnldsv skjnldsv merged commit 6e279bf into stable20 Nov 24, 2020
@skjnldsv skjnldsv deleted the backport/24341/stable20 branch November 24, 2020 17:38
This was referenced Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants