Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code from checking core/apps before upgrades #24384

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Remove dead code from checking core/apps before upgrades #24384

merged 1 commit into from
Mar 17, 2021

Conversation

juliusknorr
Copy link
Member

All those methods were not called for a long time, basically since the check for db migration of core and apps was dropped in #1549 (Nextcloud 11)

@juliusknorr juliusknorr added this to the Nextcloud 21 milestone Nov 26, 2020
blizzz
blizzz approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🧹 ✨

ChristophWurst
ChristophWurst reviewed Nov 26, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 🌱 🐦

ChristophWurst
ChristophWurst approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused so much on the emojis that I forgot to switch to approve

@nickvergessen
Copy link
Member

Ci is not happy:

PDOException: SQLSTATE[HY000]: General error: 1 no such table: ownc_appconfig

@juliusknorr juliusknorr force-pushed the cleanup/remove-old-migration-check branch from c477686 to f072127 Compare November 26, 2020 14:32
rullzer
rullzer approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase and squash the fixup. Then good to go i think

@juliusknorr juliusknorr force-pushed the cleanup/remove-old-migration-check branch from f072127 to 1c2a9b4 Compare December 9, 2020 12:55
@rullzer rullzer mentioned this pull request Dec 14, 2020
Merged
59 tasks
@juliusknorr juliusknorr force-pushed the cleanup/remove-old-migration-check branch from 1c2a9b4 to 24c17f5 Compare December 14, 2020 10:19
@PVince81
Copy link
Member

a lot of conflicts have appeared

@MorrisJobke
Copy link
Member

Let me rebase

@MorrisJobke MorrisJobke force-pushed the cleanup/remove-old-migration-check branch from 24c17f5 to b050736 Compare March 17, 2021 16:52
@MorrisJobke
Copy link
Member

Rebased 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 17, 2021
@juliusknorr @MorrisJobke
Skip db migration simulation for core schema changes
a2f3077 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@MorrisJobke MorrisJobke force-pushed the cleanup/remove-old-migration-check branch from b050736 to a2f3077 Compare March 17, 2021 20:08
@MorrisJobke
Copy link
Member

Fixed the CS complaint (was an unused use statement)

@MorrisJobke MorrisJobke merged commit 37feee4 into master Mar 17, 2021
@MorrisJobke MorrisJobke deleted the cleanup/remove-old-migration-check branch March 17, 2021 20:29
come-nc added a commit that referenced this pull request Aug 22, 2022
@come-nc
Remove listeners of \OC\DB\Migrator::checkTable which is never emitted
d0c5ba3 
See commit a2f3077 from PR #24384

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc added a commit that referenced this pull request Aug 23, 2022
@come-nc
Remove listeners of \OC\DB\Migrator::checkTable which is never emitted
3d50792 
See commit a2f3077 from PR #24384

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc added a commit that referenced this pull request Aug 25, 2022
@come-nc
Remove listeners of \OC\DB\Migrator::checkTable which is never emitted
a423a8b 
See commit a2f3077 from PR #24384

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc added a commit that referenced this pull request Aug 25, 2022
@come-nc
Remove listeners of \OC\DB\Migrator::checkTable which is never emitted
5aac997 
See commit a2f3077 from PR #24384

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.
7 participants
@juliusknorr @nickvergessen @PVince81 @MorrisJobke @rullzer @ChristophWurst @blizzz