Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Respect default share permissions #24437

Merged
merged 1 commit into from
Nov 30, 2020
Merged

[stable18] Respect default share permissions #24437

merged 1 commit into from
Nov 30, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 29, 2020 •
edited by MorrisJobke
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #21963

Fixed #22173

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.12 milestone Nov 29, 2020
@MorrisJobke
Copy link
Member

/compile amend /

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Nov 29, 2020
@rullzer @npmbuildbot-nextcloud
Respect default share permissions
b9ae791 
Else we'll always create new shares with the max permissions.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
@faily-bot
Copy link

faily-bot bot commented Nov 30, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 36057: failure

handlebars

@MorrisJobke MorrisJobke merged commit b050c1f into stable18 Nov 30, 2020
@MorrisJobke MorrisJobke deleted the backport/21963/stable18 branch November 30, 2020 09:08
@MorrisJobke MorrisJobke mentioned this pull request Nov 30, 2020
Merged
This was referenced Dec 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

@georgehrke georgehrke Awaiting requested review from georgehrke

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: sharing regression
Projects
None yet
Milestone
Nextcloud 18.0.12
Development

Successfully merging this pull request may close these issues.
3 participants
@MorrisJobke @skjnldsv @rullzer