dont offer to edit external config settings if we can't edit them #24661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
approved these changes
Dec 14, 2020
juliusknorr
force-pushed
the
external-storage-cant-edit
branch
from
9df23d2 to
ce45787
Compare
|
Rebased and pushed a fix for the tests |
juliusknorr
force-pushed
the
external-storage-cant-edit
branch
from
ce45787 to
2c669db
Compare
juliusknorr
approved these changes
Dec 28, 2020
juliusknorr
force-pushed
the
external-storage-cant-edit
branch
from
2c669db to
2e94b3d
Compare
MorrisJobke
reviewed
Jan 7, 2021
|
CI fails. |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
external-storage-cant-edit
branch
from
be163c5 to
518e91b
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
CI is happy (except for our scheduled mysql test timeout) |
MorrisJobke
approved these changes
Jan 11, 2021
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no need to confuse the user by providing options that he cant use.