[Fix #24682]: ensure federation cloud id is retruned if FN property not found #24683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doc75
force-pushed
the
federation_confidentiality
branch
from
72d77fb to
212df7c
Compare
…roperty not found Signed-off-by: Guillaume Virlet <github@virlet.org>
doc75
force-pushed
the
federation_confidentiality
branch
from
212df7c to
83491c6
Compare
|
/backport to stable20 |
|
/backport to stable19 |
juliusknorr
approved these changes
Dec 15, 2020
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
yeah. i thought this is a required field. |
|
/backport to stable20 |
|
/backport to stable19 |
|
The backport to stable20 failed. Please do this backport manually. |
|
/backport to stable20 |
|
The backport to stable20 failed. Please do this backport manually. |
blizzz
referenced
this pull request
Jan 5, 2021
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing #24682
I have tested it on my migrated instance (19.0.6) and it is working fine.
Let me know if anything is missing or need to be reworked (I am not an expert)