-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify the boundary element of the Actions menu #24694
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 456: failuremysql8.0-php7.4Show full log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no Idea about te "data-v..." attributes being the same. I checked the values bound as keys to the elements in the v-for loop and they're different. @skjnldsv or @juliushaertl ideas? |
sadly doesn't fix #23617 as I hoped. |
All same scoped-elements get the same vue scope id. |
sooooo next steps? |
So, while this fixes the scrolling issue in the sidebar. It seems totally broken for multiple link shares now.
After inspecting, I saw they get the same vue element id?
This is already the case in master, but maybe due to the missing boundary-element it didn't matter before. Now the first items opens with an offset and the second item opens just on top of all the things, instead of "bellow" the action three-dot
@skjnldsv @juliushaertl @ma12-co any idea?
Fix #23872