Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the boundary element of the Actions menu #24694

Closed
wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

So, while this fixes the scrolling issue in the sidebar. It seems totally broken for multiple link shares now.
After inspecting, I saw they get the same vue element id?

Bildschirmfoto von 2020-12-14 16-03-34

This is already the case in master, but maybe due to the missing boundary-element it didn't matter before. Now the first items opens with an offset and the second item opens just on top of all the things, instead of "bellow" the action three-dot
@skjnldsv @juliushaertl @ma12-co any idea?

Fix #23872

Signed-off-by: Joas Schilling <coding@schilljs.com>
@faily-bot
Copy link

faily-bot bot commented Dec 14, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 456: failure

mysql8.0-php7.4

Show full log
There was 1 error:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testFOpen with data set #3 ('file with space.txt')
stream_get_contents() expects parameter 1 to be resource, bool given

/drone/src/tests/lib/Files/Storage/Storage.php:385

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\ShareByMail\Tests\ShareByMailProviderTest::testRemoveShareFromTable
Failed asserting that 0 is identical to 1.

/drone/src/apps/sharebymail/tests/ShareByMailProviderTest.php:846

@skjnldsv skjnldsv removed their request for review December 15, 2020 07:48
This was referenced Dec 15, 2020
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working on my machine™, apart from that small offset on the first element.

Peek 2020-12-18 15-07

@marcoambrosini
Copy link
Member

I have no Idea about te "data-v..." attributes being the same. I checked the values bound as keys to the elements in the v-for loop and they're different. @skjnldsv or @juliushaertl ideas?

This was referenced Dec 28, 2020
@rullzer rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Jan 8, 2021
@PVince81
Copy link
Member

PVince81 commented Feb 5, 2021

sadly doesn't fix #23617 as I hoped.
that one is probably another issue

@skjnldsv
Copy link
Member

After inspecting, I saw they get the same vue element id?

All same scoped-elements get the same vue scope id.
The data-xxx is not an id used by vue, they will be shared across all similar components on build. This is not an issue with the boundaries

@rullzer
Copy link
Member

rullzer commented Mar 30, 2021

sooooo next steps?

@nickvergessen nickvergessen deleted the bugfix/23872/fix-menu-position branch April 22, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share link menu going craaaaaaazy on scroll
5 participants