-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure we properly ass well-known paths to index.php #24860
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
1de612c
to
98198e0
Compare
@daita please test with your setups :) |
green test on:
👍 |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 790: failurejsunitShow full log
|
Not really important as there is a work around, but ... Did some more test with nextcloud in a sub folder/path: https://example.net:8081/nextcloud/ With default setup, I just need (in apache config) to redirect the request from Now, with |
This makes sure we pass .well-known paths to index.php if they are not acme-challenge|pki-validation. The fallback for random files starting with "." is still preserved. Otherwise the rewrite to a 404 status page will cause issues with the get parameters not being preserved when the 404 is handled by our own ErrorDocument handling in
server/lib/private/Setup.php
Line 523 in d89a75b
Ref #24702