Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Make share results distinguishable if there are more than one with the exact same display name #24878

Merged
merged 4 commits into from
Jan 5, 2021

Conversation

juliusknorr
Copy link
Member

Backport of #23017

@juliusknorr juliusknorr added this to the Nextcloud 20.0.5 milestone Dec 29, 2020
@juliusknorr juliusknorr changed the title Make share results distinguishable if there are more than one with the exact same display name [stable20] Make share results distinguishable if there are more than one with the exact same display name Dec 29, 2020
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer
Copy link
Member

rullzer commented Jan 5, 2021

The fixupbot is not happy!

@rullzer rullzer mentioned this pull request Jan 5, 2021
1 task
…e exact same display name

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 5, 2021
@juliusknorr juliusknorr force-pushed the backport/stable20/23017 branch from 9769db2 to 24053ed Compare January 5, 2021 09:06
@juliusknorr
Copy link
Member Author

Static analysis errors unrelated, also fail on the last merged commit https://github.com/nextcloud/server/runs/1621333611

@juliusknorr juliusknorr merged commit 2f6b2b6 into stable20 Jan 5, 2021
@juliusknorr juliusknorr deleted the backport/stable20/23017 branch January 5, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants