Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Symfony dispatcher correctly #24892

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

ChristophWurst
Copy link
Member

  • Event object as first arg (otherwise there is a notice in the logs)
  • dispatch MUST return the event object

@juliusknorr

This comment has been minimized.

This was referenced Dec 30, 2020
@ChristophWurst ChristophWurst force-pushed the fix/use-symfony-dispatcher-correctly branch from 3bdad27 to d820c97 Compare January 5, 2021 14:59
* Event object as first arg (otherwise there is a notice in the logs)
* `dispatch` MUST return the event object

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the fix/use-symfony-dispatcher-correctly branch from d820c97 to 85454ac Compare January 5, 2021 15:00
@ChristophWurst ChristophWurst requested review from juliusknorr and removed request for juliusknorr January 5, 2021 16:35
@faily-bot
Copy link

faily-bot bot commented Jan 5, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 989: failure

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log
  Scenario: users navigation without disabled users                                   # /drone/src/tests/acceptance/features/users.feature:47
    Given I act as Jane                                                               # ActorContext::iActAs()
    And I am logged in as the admin                                                   # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                      # SettingsMenuContext::iOpenTheUserSettings()
    And I open the "Disabled users" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the list of users contains the user disabledUser                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user disabledUser                             # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user disabledUser in Users Settings could not be found
      Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
    And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Enable user" action in the disabledUser actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()
    When I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    Then I see that the section "Disabled users" is not shown                         # AppNavigationContext::iSeeThatTheSectionIsNotShown()

@MorrisJobke MorrisJobke merged commit 1e3c071 into master Jan 7, 2021
@MorrisJobke MorrisJobke deleted the fix/use-symfony-dispatcher-correctly branch January 7, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants