-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump doctrine/dbal from 2.12.0 to 3.0.0 #24948
Bump doctrine/dbal from 2.12.0 to 3.0.0 #24948
Conversation
https://github.com/doctrine/dbal/releases/tag/3.0.0 That are many changes 😨 |
Yes. And it's landing at a very unfortunate time for us. They won't release the 2.x for php8, so we either upgrade to 3.x for 21 or we'll have loads of problems later on. |
20ab393
to
8c54700
Compare
c0bbcc7
to
b1e988a
Compare
This comment has been minimized.
This comment has been minimized.
366e124
to
434bd66
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
…s not used anymore and triggers an exception See doctrine/dbal@138eb85#diff-300f55366adb50a32a40882ebdc95c163b141f64cba5f45f20bda04a907b3eb3L82 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
434bd66
to
f0c6cfd
Compare
…un into docker pull rate limits Signed-off-by: Morris Jobke <hey@morrisjobke.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Quick smoke test also looked good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 For Morris' parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works here 👍
Required for php8 compat.
Changed APIs
$qb->execute()->fetch()
"lost" the second and third parameter that we never used$qb->execute()->fetchColumn()
"lost" its argument ->fetchOne
should be used instead, our code never supplied anything but0
as first arg so this is fine$db->prepare()->execute()
gives you a result object or throws, it does not returnfalse
anymore. We could still return false but that completely swallows the error.Vanished APIs (e.g. because the new adapter can't provide them)
$qb->execute()->bindParam()
(not used anyway)$qb->execute()->bindValue()
(not used anyway)$qb->execute()->columnCount()
(not used anyway)$qb->execute()->errorCode()
(not used anyway)$qb->execute()->errorInfo()
(not used anyway)$qb->execute()->setFetchMode()
(not used anyway)Todo
fetchAll
Details of the breaking changes: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed