Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Add migration for oc_share_external columns #24963

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jan 5, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #24829

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 20.0.5 milestone Jan 5, 2021
@rullzer rullzer added the 3. to review Waiting for reviews label Jan 5, 2021
@rullzer
Copy link
Member

rullzer commented Jan 5, 2021

@PVince81 @juliushaertl can you check the conflict?

@rullzer rullzer mentioned this pull request Jan 6, 2021
1 task
Add column "parent" if missing.
Drop column "lastscan" if exists.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@juliusknorr juliusknorr force-pushed the backport/24829/stable20 branch from 176f272 to 9c7d733 Compare January 7, 2021 08:39
@juliusknorr
Copy link
Member

Rebased and added the missing version bump for the files_sharing app.

@faily-bot
Copy link

faily-bot bot commented Jan 7, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1057: failure

mariadb10.1-php7.2

Show full log
 bash tests/drone-run-php-tests.sh || exit 0
=========================
= List of changed files =
=========================
apps/files_sharing/appinfo/info.xml
apps/files_sharing/composer/composer/autoload_classmap.php
apps/files_sharing/composer/composer/autoload_static.php
apps/files_sharing/lib/Migration/Version11300Date20201120141438.php
apps/files_sharing/lib/Migration/Version21000Date20201223143245.php
=========================
bash files are modified
+ NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mariadb
Using PHP executable /usr/bin/php
Using database oc_autotest
Setup environment for mariadb testing on local storage ...
Waiting for MariaDB initialisation ...
...........................................................................................................................................................................................................................................................................................................
[ERROR] Waited 300 seconds, no respons

mysql8.0-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ViewTest::testDeleteGhostFolder
Failed asserting that '5ff6d62200fa2' is not equal to '5ff6d62200fa2'.

/drone/src/tests/lib/Files/ViewTest.php:2618

@rullzer rullzer merged commit 2dbf407 into stable20 Jan 7, 2021
@rullzer rullzer deleted the backport/24829/stable20 branch January 7, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants