Fix warning in PHP 8 about optional parameter before mandatory one #25004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
rullzer,
ChristophWurst,
blizzz,
kesselb and
skjnldsv
rullzer
reviewed
Jan 7, 2021
| @@ -56,7 +56,7 @@ class File extends LogDetails implements IWriter, IFileBased { | |||
| /** @var SystemConfig */ | |||
| private $config; | |||
|
|
|||
| public function __construct(string $path, string $fallbackPath = '', SystemConfig $config) { | |||
| public function __construct(string $path, string $fallbackPath, SystemConfig $config) { | |||
There was a problem hiding this comment.
Yes, otherwise you cannot set the $config one and therefore PHP would crash initializing this object. I also checked all occurrences of this to be sure xD
There was a problem hiding this comment.
Yes:
server/lib/private/Log/LogFactory.php
Line 78 in 2dd04f7
ChristophWurst
approved these changes
Jan 7, 2021
| @@ -56,7 +56,7 @@ class File extends LogDetails implements IWriter, IFileBased { | |||
| /** @var SystemConfig */ | |||
| private $config; | |||
|
|
|||
| public function __construct(string $path, string $fallbackPath = '', SystemConfig $config) { | |||
| public function __construct(string $path, string $fallbackPath, SystemConfig $config) { | |||
There was a problem hiding this comment.
Yes:
server/lib/private/Log/LogFactory.php
Line 78 in 2dd04f7
kesselb
approved these changes
Jan 7, 2021
MorrisJobke
deleted the
fix/noid/php8-optional-parameter-before-mandatory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.