Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Fix column name to check prior to deleting #25009

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #25001

Signed-off-by: Joas Schilling <coding@schilljs.com>
@faily-bot
Copy link

faily-bot bot commented Jan 7, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1087: failure

mysql5.6-php7.2

Show full log
There was 1 error:

1) Test\Share20\DefaultShareProviderTest::testDeleteFromSelfUser
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/lib/private/Share20/DefaultShareProvider.php:763
/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1679

acceptance-users

  • tests/acceptance/features/users.feature:35
Show full log
  Scenario: disable a user                                                      # /drone/src/tests/acceptance/features/users.feature:35
    Given I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in as the admin                                             # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0                    # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the actions menu for the user user0                              # UsersSettingsContext::iOpenTheActionsMenuOf()
      Row for user user0 in Users Settings could not be found
      Actions menu for user user0 in Users Settings could not be found (NoSuchElementException)
    And I see that the "Disable user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
    When I click the "Disable user" action in the user0 actions menu            # UsersSettingsContext::iClickTheAction()
    Then I see that the list of users does not contains the user user0          # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
    When I open the "Disabled users" section                                    # AppNavigationContext::iOpenTheSection()
    Then I see that the list of users contains the user user0                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()

@rullzer rullzer merged commit 102a6fe into stable20 Jan 7, 2021
@rullzer rullzer deleted the backport/25001/stable20 branch January 7, 2021 18:46
@rullzer rullzer mentioned this pull request Jan 7, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants