Make sure to do priority app upgrades first #25034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise those apps might not be loaded when the others app migrations are running. The previous loading of authentication apps in the upgrade step never worked as it just returns in maintenance mode Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
rullzer,
MorrisJobke,
PVince81,
ChristophWurst and
blizzz
juliusknorr
commented
Jan 8, 2021
| @@ -267,7 +267,6 @@ private function doUpgrade($currentVersion, $installedVersion) { | |||
| $this->upgradeAppStoreApps($autoDisabledApps, true); | |||
|
|
|||
| // install new shipped apps on upgrade | |||
| OC_App::loadApps(['authentication']); | |||
There was a problem hiding this comment.
We are in maintenance mode here already, so this never worked due to
server/lib/private/legacy/OC_App.php
Lines 116 to 117 in d89a75b
|
/backport to stable20 |
|
/backport to stable19 |
|
/backport to stable18 |
blizzz
approved these changes
Jan 8, 2021
blizzz
added
4. to release
MorrisJobke
deleted the
bugfix/noid/load-authentication-for-app-upgrades
branch
This was referenced Jan 11, 2021
|
@rullzer Something for todays RCs or next ones? |
|
If the next ones, then we can close the 18 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise those apps might not be loaded when the others app migrations are running. The previous loading of authentication apps in the upgrade step never worked as it just returns in maintenance mode.
This has shown causing issues with deck for example where we have a cleanup migration step that checks if a user exists. Now when running this post-migration step with LDAP users the user_ldap app would have never been loaded as the
othersapps get upgraded first, which leads to the user existance check to always return false.