-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DAVx5 in AuthToken.vue #25084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
I'm also fine if we leave the old user agent in for any older clients? Or is that too unlikely that someone still uses the davDroid app?
Yes I'd keep the |
/compile amend / |
1. It's named DAVx5 (only very old clients have DAVdroid in the User-Agent) 2. Use passive matching (?:droid|x5) because otherwise, "x5" is recognized and shown as operating system 3. Also include the version postfix which contains information like "-beta2", which is important for the user Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Hi,
Please have a look at these changes:
Is renaming the constant
davDroid
todavx5
somehow problematic?