Update psalm baseline to remove obsolete stuff #25087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen in CI static checks, some blocks in the baseline were not needed any more. This will fix static checks in CI. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
requested review from
rullzer,
nickvergessen,
MorrisJobke,
ChristophWurst and
juliusknorr
|
okay, there's an extra error: fixing... |
nickvergessen
approved these changes
Jan 12, 2021
ChristophWurst
approved these changes
Jan 12, 2021
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
|
@PVince81 In general there should be updates to the baseline every day (if there are any) automatically: https://github.com/nextcloud/server/blob/master/.github/workflows/update-psalm-baseline.yml |
MorrisJobke
approved these changes
Jan 12, 2021
MorrisJobke
deleted the
techdebt/noid/update-psalm-baseline-as-recommended.xml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in CI static checks, some blocks in the baseline were not needed any
more.
This will fix static checks in CI which were failing in multiple PRs, like https://github.com/nextcloud/server/pull/25086/checks?check_run_id=1685442983 and https://github.com/nextcloud/server/pull/24606/checks?check_run_id=1682178510
This is the result of running locally
composer run psalm -- --update-baseline --threads=1Signed-off-by: Vincent Petry vincent@nextcloud.com