Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the actual error on share requests #25185

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Show the actual error on share requests #25185

merged 1 commit into from
Jan 18, 2021

Conversation

juliushaertl
Copy link
Member

  • Put an incoming share into a new directory
  • Try to share the directory

This will make sure you see a proper error why the share creation has failed Error creating the share: Path contains files shared with you instead of a generic Error creating the share

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer rullzer merged commit de564f8 into master Jan 18, 2021
@rullzer rullzer deleted the bugfix/share-errors branch January 18, 2021 19:19
@rullzer rullzer mentioned this pull request Jan 19, 2021
15 tasks
@juliushaertl
Copy link
Member Author

/backport to stable20

@juliushaertl
Copy link
Member Author

/backport to stable19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants