Fix encoding issue with OC.Notification.show #25234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
/backport to stable20 |
|
/backport to stable19 |
rullzer
approved these changes
Jan 20, 2021
skjnldsv
approved these changes
Jan 21, 2021
skjnldsv
deleted the
bugfix/noid/fix-encoding-issue-with-oc.notification.show
branch
|
The backport to stable19 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename an existing filename to
<img src=x onerror=prompt(1)>.jpg.Try to rename
<img src=x onerror=prompt(1)>.jpgwith an invalid filename, like add a\in it, will trigger the XSS attack.