Improve mention matches #25378
Merged
Improve mention matches #25378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
reviewed
Jan 29, 2021
There was a problem hiding this comment.
Tested and notifications when a comment is something like Hi @user0 and @user0-2 now work 👍
Mentioning a user using quotes does not work, though. But id did not work before even for users with spaces in the name (Hello @""user0 1"" is shown in the comment), so it might be something for a different pull request.
Edit: clarification, it does not work when rendered in the comments app. But it does in the notification.
danxuliu
approved these changes
Jan 29, 2021
|
Linter says no |
rullzer
approved these changes
Feb 1, 2021
nickvergessen
added
4. to release
|
Master is Nextcloud 22 now. |
|
/backport to stable21 |
The previous regex didn't correctly match users with . ' or - Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
rullzer
force-pushed
the
bugfix/noid/mention-match-improvements
branch
from
46e82aa to
9803242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous regex didn't correctly match users with . ' or -
Signed-off-by: Joas Schilling coding@schilljs.com