-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable20] do not remove valid group shares #25384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
blizzz,
ChristophWurst,
kesselb and
rullzer
January 29, 2021 10:44
blizzz
approved these changes
Jan 29, 2021
ChristophWurst
approved these changes
Jan 29, 2021
Merged
seems psalm-baseline needs updating |
Merged
rullzer
force-pushed
the
backport/25218/stable20
branch
from
February 17, 2021 07:51
31c7496
to
bf61a43
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 2353: failureacceptance-app-files
Show full log
|
rullzer
approved these changes
Feb 17, 2021
How do i preach it to Psalm? The return types have not changed with this PR and could have been null, though not pointed out by phpdoc, since about a decade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #25218