-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable20] Remove stray compiled assets #25480
Conversation
This was automatically deleted and not regenerated by: make dev-setup && make build-js-production Signed-off-by: Vincent Petry <vincent@nextcloud.com>
I've had a quick test of the users page and it seemed to work fine. The matching acceptance tests will also confirm this. |
restarted CI for hopefully slightly greener results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to do the same in another PR
Yes, the settings chunk names are chaning on every build update so they maybe a not cleaned up build has made it to the base branch. |
Actually we should have #24865 for stable20 as well |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1950: failureacceptance-app-files-sharing
Show full log
|
failures seem unrelated: both in acceptance tests for sharing |
I've raised #25491 to look into the failed sharing acceptance test as it seems to happen consistently on stable20. |
This was automatically deleted and not regenerated by:
make dev-setup && make build-js-production
I ran those on stable20 and committed the result.
I didn't see this happen on stable21 or master, so probably it's assets that exist since a while and were never properly deleted.
Also: CI did not complain about those missing.
Removing these will avoid devs to be confused like I was in #25475 especially when changing seemingly related files.