Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] fix(translation): replace static error message #25507

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #25500

as suggested by @kesselb in #25490

Signed-off-by: Samuel <faust64@gmail.com>
Signed-off-by: Samuel <faust64@gmail.com>
Signed-off-by: Samuel <faust64@gmail.com>
@faily-bot
Copy link

faily-bot bot commented Feb 5, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1987: failure

mariadb10.1-php7.2

Show full log
There were 5 warnings:

1) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParameterTooLarge
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

2) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParametersTooMany
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

3) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

4) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

5) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

--

There was 1 failure:

1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testDeleteUser with data set #1 ('a', 'b', 'c', 'b', false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:761

mysql8.0-php7.2

Show full log
There were 5 warnings:

1) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParameterTooLarge
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

2) Test\DB\QueryBuilder\QueryBuilderTest::testExecuteWithParametersTooMany
Cannot stub or mock class or interface "Doctrine\DBAL\Result" which does not exist

3) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

4) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

5) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

--

There were 2 failures:

1) Test\Comments\ManagerTest::testSaveUpdateException
Failed asserting that exception of type "InvalidArgumentException" matches expected exception "OCP\Comments\NotFoundException". Message was: "IDs must be translatable to a number in this implementation." at
/drone/src/lib/private/Comments/Manager.php:248
/drone/src/lib/private/Comments/Manager.php:809
/drone/src/lib/private/Comments/Manager.php:729
/drone/src/tests/lib/Comments/ManagerTest.php:517
.

2) Test\Share20\DefaultShareProviderTest::testGetSharedWithUserWithNode with data set #1 ('smb::whatever', 'files/test.txt', 'files/test2.txt')
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1166

@rullzer rullzer added the 3. to review Waiting for reviews label Feb 6, 2021
@rullzer rullzer requested review from PVince81 and kesselb February 8, 2021 20:28
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

PVince81 commented Feb 9, 2021

does the translation bot also operate on stable branches though or do we need to backport to translation files as well once there is one ?

@rullzer rullzer merged commit 7bcfbc8 into stable19 Feb 9, 2021
@rullzer rullzer deleted the backport/25500/stable19 branch February 9, 2021 13:37
@rullzer
Copy link
Member

rullzer commented Feb 9, 2021

does the translation bot also operate on stable branches though or do we need to backport to translation files as well once there is one ?

yes it does

@rullzer rullzer mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants