disable trasbin during the moveFromStorage fallback #25568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
approved these changes
Feb 11, 2021
ChristophWurst
approved these changes
Feb 11, 2021
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
move-storage-disable-cache
branch
from
e754aad to
b5db450
Compare
|
/backport to stable21 |
|
/backport to stable20 |
This was referenced May 14, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
moveFromStoragefallback does acopy+delete, currently the second half triggers the trashbin logic which causes it to move the sourcefile to the trashbin and give the move target a different fileid.