file-upload: Correctly handle error responses for HTTP2 #25569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Onderka <ahoj@jakubonderka.cz>
JakubOnderka
force-pushed
the
JakubOnderka-patch-1
branch
from
8195259 to
296ffc7
Compare
|
PING |
ChristophWurst
approved these changes
Mar 11, 2021
|
/backport to stable21 |
|
/backport to stable20 |
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
This was referenced Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For HTTP2,
errorThrownvariable can be empty string:So for Chrome or Safari, that follows HTTP/2 specs, Nextcloud will not parse error message. This makes problem at least for AV plugin – see nextcloud/files_antivirus#119
I would be happy if it is be possible to also apply this patchto version 19.X.