-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch notfound and forbidden exception in smb::getmetadata #25659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested changes
Feb 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
psalm says no
icewind1991
force-pushed
the
smb-getmetadata-catch
branch
2 times, most recently
from
February 16, 2021 13:17
ea3ce59
to
a1a987f
Compare
made psalm happy |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 2337: failureacceptance-app-files-sharing
Show full log
|
juliusknorr
approved these changes
Feb 16, 2021
/backport to stable21 |
/backport to stable20 |
rullzer
force-pushed
the
smb-getmetadata-catch
branch
from
March 4, 2021 20:34
a1a987f
to
b844293
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzer
approved these changes
Mar 5, 2021
This was referenced Mar 5, 2021
/backport to stable19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle those errors during scanning as files that don'