Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger a full filelist reload after creating a new file from a template #25797

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

juliusknorr
Copy link
Member

Instead of reloading the full file list after creating a file from a template this will now just fetch the single file info and add it to the existing file list. This makes sure we can also provide the regular context parameters when calling the file action.

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Feb 25, 2021
@juliusknorr juliusknorr added this to the Nextcloud 22 milestone Feb 25, 2021
@juliusknorr
Copy link
Member Author

/backport to stable21

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rullzer
Copy link
Member

rullzer commented Mar 2, 2021

php-cs is not happy..

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/templates-fileactions branch from 8df45b6 to 1d5ee03 Compare March 2, 2021 09:46
@juliusknorr
Copy link
Member Author

Rebased

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants