Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw an exception when php-xml is missing #2619

Closed

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 12, 2016

@LukasReschke I guess we can also backport this later, so up to you if 11 or not

Fix #2180

Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ringmaster, @LukasReschke and @bartv2 to be potential reviewers.

@LukasReschke
Copy link
Member

I guess this is because the compatibility check is performed later? Would an alternative be to move the compatibility check higher?

@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 12, 2016

Well the check uses language, therefor requires the user session, therefor session apps need to be loaded already => 🙈

@nickvergessen
Copy link
Member Author

On the otherhand this stuff doesnt happen accidentially. So I guess an english only message would also be fine.

@rullzer
Copy link
Member

rullzer commented Dec 14, 2016

I would be fine by not having this message translated.

@rullzer rullzer added this to the Nextcloud 12.0 milestone Dec 16, 2016
@MorrisJobke
Copy link
Member

@nickvergessen Could you fix this?

@MorrisJobke
Copy link
Member

@nickvergessen Could you fix this?

Why do we even initialize a session if the instance is not yet installed. Maybe we could fix this the other way around.

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 26, 2017
@nickvergessen
Copy link
Member Author

Sorry that will be way more work. Feel free to do that. It needs major changes in base.php and the Setup class.

@nickvergessen nickvergessen deleted the issue-2180-no-exception-when-php-xml-is-missing branch January 27, 2017 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants